feat(managedmetric)!: new target spec field #89
Merged
+55
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophrj
force-pushed
the
feat/managed-metric-spec-target-breaking-change
branch
2 times, most recently
from
f6939d7 to
1cff434
Compare
BREAKING CHANGE: the new target GVK type replaces the single GVK fields to implement a consistent API across all metric types Users have to migrate any existing ManagedMetrics manually when upgrading the operator. On-behalf-of: @SAP [email protected] Signed-off-by: Christopher Junk <[email protected]>
christophrj
force-pushed
the
feat/managed-metric-spec-target-breaking-change
branch
from
1cff434 to
7de6619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces the single GVK types in ManagedMetric with the existing composite GVK type from Metric to implement a consistent API.
Which issue(s) this PR fixes:
Fixes #79
Special notes for your reviewer:
Release note: